What is the best way to get shinies in pokemon diamond?

There really isn't a best way. The odds of a PokeMon being shiny is 1/8125. So the odds aren't good. The easy way is using an illegal software, like AR or Gameshark. But those could easily mess up your game.